Add Mlflow 403 PL UserError #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
Oct 30, 2024
dakinggg
reviewed
Oct 30, 2024
dakinggg
approved these changes
Oct 30, 2024
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
nancyhung
reviewed
Oct 30, 2024
nancyhung
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Can we also add a try/catch to the read operation when we download data via uc.files.download(...)? @mattyding
I thought motivation for the PFC->wrapping change is that we have no examples of customer runs with data read errors and can't validate the PFC check. So any try/catch wrapping we do for read would be a best guess. I say we proceed with just the 403 artifacts error for now because we have ample evidence for that. If another data read error comes up (still waiting on Rohit's logs), then can add another wrap |
dakinggg
added a commit
that referenced
this pull request
Nov 1, 2024
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
dakinggg
added a commit
that referenced
this pull request
Nov 1, 2024
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds networking UserError to Foundry.
Abandoning PFC change in favor of this. This try-catch should sufficiently cover the 403 networking errors we are seeing. Additionally, change is safer as it avoids duplicating logic in composer.
Testing
Was gonna add a unit test that mocked a MLflow 500 exception but the test doesn't really fit anywhere in the testing suite and has strong assumptions, so not much benefit. Idk if others have thoughts
Rollout (including migrations)
DLE release