Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typing (part 1) #240

Merged
merged 8 commits into from
Jun 27, 2023
Merged

Fix Typing (part 1) #240

merged 8 commits into from
Jun 27, 2023

Conversation

hanlint
Copy link
Collaborator

@hanlint hanlint commented May 28, 2023

This is the first in a series of PRs that brings this library into compliance with pyright. No functional changes to the code should occur with these fixes.

Before:

68 errors, 610 warnings, 0 informations 

After:

28 errors, 443 warnings, 0 informations 

@hanlint hanlint requested review from dakinggg and vchiley May 31, 2023 16:32
llmfoundry/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did pyright get removed from CI 🙈

bmosaicml pushed a commit that referenced this pull request Jun 6, 2023
* refactor attn layers

* enable cross attn

* adding unpacked flash and torch

* cleanup

* lint

* pass attn fn thu __init__

* refac

* mv bias subset

* pr cmts & enable non-causal alibi

* fool proof tests
@vchiley vchiley requested a review from dakinggg June 27, 2023 18:56
@vchiley vchiley merged commit dea59aa into main Jun 27, 2023
@dakinggg dakinggg deleted the hanlin/fix_typing branch October 11, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants