-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Typing (part 1) #240
Merged
Merged
Fix Typing (part 1) #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchiley
reviewed
May 31, 2023
vchiley
reviewed
May 31, 2023
vchiley
reviewed
May 31, 2023
vchiley
reviewed
May 31, 2023
vchiley
reviewed
May 31, 2023
dakinggg
reviewed
May 31, 2023
dakinggg
reviewed
May 31, 2023
dakinggg
reviewed
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When did pyright get removed from CI 🙈
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
* refactor attn layers * enable cross attn * adding unpacked flash and torch * cleanup * lint * pass attn fn thu __init__ * refac * mv bias subset * pr cmts & enable non-causal alibi * fool proof tests
vchiley
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first in a series of PRs that brings this library into compliance with
pyright
. No functional changes to the code should occur with these fixes.Before:
After: