Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change mcli eval YAMLs to use mixed_precision: FULL #255

Merged
merged 3 commits into from
May 31, 2023
Merged

Change mcli eval YAMLs to use mixed_precision: FULL #255

merged 3 commits into from
May 31, 2023

Conversation

abhi-mosaic
Copy link
Contributor

@abhi-mosaic abhi-mosaic commented May 31, 2023 •
edited
Loading

We have been seeing some inconsistency with MPT-7B eval with FSDP mixed_precision: PURE but everything is fine with mixed_precision: FULL. While we debug this, we should set the default values in our example YAMLs to mixed_precision: FULL.

@abhi-mosaic abhi-mosaic requested a review from dakinggg May 31, 2023 06:24
@abhi-mosaic abhi-mosaic self-assigned this May 31, 2023
bmosaicml
bmosaicml approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@bmosaicml bmosaicml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this apply to the opt eval file as well? and the yamls in the scripts/eval folder?

@abhi-mosaic
Copy link
Contributor Author

should this apply to the opt eval file as well? and the yamls in the scripts/eval folder?

I believe all the eval YAMLs should be good now with precision: fp32 and fsdp_config.mixed_precision: FULL.

@abhi-mosaic abhi-mosaic merged commit bc3b132 into main May 31, 2023
@abhi-mosaic abhi-mosaic deleted the abhi/eval_full branch June 6, 2023 15:53
bmosaicml pushed a commit that referenced this pull request Jun 8, 2023
@abhi-mosaic
Change mcli eval YAMLs to use mixed_precision: FULL (#255)
515d127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmosaicml bmosaicml bmosaicml approved these changes

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees

@abhi-mosaic abhi-mosaic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhi-mosaic @bmosaicml