Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #294

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Update README.md #294

merged 1 commit into from
Jun 7, 2023

Conversation

abhi-mosaic
Copy link
Contributor

Update the numbers in the "How many GPUs do I need..." paragraph. These old numbers were for AdamW, but the writing and math references LionW.

@abhi-mosaic abhi-mosaic requested a review from growlix June 6, 2023 20:49
@abhi-mosaic abhi-mosaic self-assigned this Jun 6, 2023
Copy link
Contributor

@growlix growlix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@growlix
Copy link
Contributor

growlix commented Jun 6, 2023

One table that would be nice to add: minimum # GPUs needed to run a given model architecture/seq len/precision format/other relevant hparams, for common GPUs (A/H100 40gb/80gb)

@abhi-mosaic
Copy link
Contributor Author

One table that would be nice to add: minimum # GPUs needed to run a given model architecture/seq len/precision format/other relevant hparams, for common GPUs (A/H100 40gb/80gb)

I'll add this to our JIRA todo for both train and inference

@abhi-mosaic abhi-mosaic merged commit 7e2be07 into main Jun 7, 2023
bmosaicml pushed a commit that referenced this pull request Jun 8, 2023
grammar check courtesy of Emily
@abhi-mosaic abhi-mosaic deleted the abhi/readme-how-many-gpus branch August 31, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants