Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages for ckpt conversion script #320

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

dskhudia
Copy link
Contributor

@dskhudia dskhudia commented Jun 13, 2023

This script expects a full composer checkpoint. Make it clear via error messages. Also change main function name as I people are using it as an api in their flow.

@dskhudia dskhudia marked this pull request as ready for review June 13, 2023 21:28
Copy link
Contributor

@abhi-mosaic abhi-mosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abhi-mosaic abhi-mosaic merged commit f5fc645 into mosaicml:main Jun 16, 2023
@dskhudia dskhudia deleted the ckpt_conversion branch June 16, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants