Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generate callback to work with precision context #322

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Fix generate callback to work with precision context #322

merged 4 commits into from
Jun 14, 2023

Conversation

dakinggg
Copy link
Collaborator

abhi-mosaic
abhi-mosaic approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@abhi-mosaic abhi-mosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakinggg dakinggg merged commit 32b36c8 into mosaicml:main Jun 14, 2023
@dakinggg dakinggg deleted the fix-gen-cb branch September 9, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-mosaic abhi-mosaic abhi-mosaic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @abhi-mosaic