Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm peft from pypi package #420

Merged
merged 1 commit into from
Jul 3, 2023
Merged

rm peft from pypi package #420

merged 1 commit into from
Jul 3, 2023

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented Jul 3, 2023

PyPI does not support direct dependencies, so we remove PEFT before PyPI build

@vchiley vchiley self-assigned this Jul 3, 2023
codestar12
codestar12 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@codestar12 codestar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vchiley vchiley merged commit 904a321 into mosaicml:main Jul 3, 2023
@vchiley vchiley deleted the sed_peft branch November 9, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codestar12 codestar12 codestar12 approved these changes

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

@dakinggg dakinggg Awaiting requested review from dakinggg

@danbider danbider Awaiting requested review from danbider

Assignees

@vchiley vchiley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchiley @codestar12