Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mcli-hf-generate.yaml #456

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Update mcli-hf-generate.yaml #456

merged 1 commit into from
Jul 12, 2023

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented Jul 12, 2023

@vchiley vchiley self-assigned this Jul 12, 2023
@vchiley vchiley requested a review from jfrankle July 12, 2023 16:59
@vchiley vchiley merged commit 2f49eb7 into main Jul 12, 2023
Michael-Pape added a commit to HeitechSoft/llm-foundry that referenced this pull request Jul 14, 2023
* Update mcli-hf-generate.yaml (mosaicml#456)

https://mosaicml.slack.com/archives/C056HNQ8XF1/p1689056584070479

* Add trust remote code for tokenizer in inference conversion script (mosaicml#446)

* add trust remote code for tokenizer

* lint

* lint

* setup.py: replace composer with mosaicml (mosaicml#458)

When we build mosaicml with "pip install -e .", we'll see package
mosaicml is installed with link to the code tree of composer.

Without this change, we'll see package composer is again installed
without link to the code tree of composer. mosaicml and composer
are two different packages and llm-foundry will call into package
composer which is not what we expect.

With this change, llm-foundry will call into the code tree of
composer which is our expectation.

---------

Co-authored-by: Vitaliy Chiley <6439018+vchiley@users.noreply.github.com>
Co-authored-by: Margaret Qian <ymqian@gmail.com>
Co-authored-by: Guo Yejun <yejun.guo@intel.com>
@dakinggg dakinggg deleted the vitaliy/patch branch October 11, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants