Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated StreamingTextDataset to pass take in shuffle_block_size #503

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Updated StreamingTextDataset to pass take in shuffle_block_size #503

merged 1 commit into from
Aug 3, 2023

Conversation

snarayan21
Copy link
Contributor

@snarayan21 snarayan21 commented Aug 3, 2023 •
edited
Loading

makes sure StreamingTextDataset takes in shuffle_block_size when initialized.

@snarayan21 snarayan21 changed the title Updated StreamingTextDataloader to pass take in shuffle_block_size Updated StreamingTextDataset to pass take in shuffle_block_size Aug 3, 2023
abhi-mosaic
abhi-mosaic approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@abhi-mosaic abhi-mosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @snarayan21 !

@abhi-mosaic abhi-mosaic merged commit 358e064 into mosaicml:main Aug 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-mosaic abhi-mosaic abhi-mosaic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snarayan21 @abhi-mosaic