-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not update past_key_values in place #652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from my comment on the test. Also wait for @vchiley to look please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: presents
implies the current x, not the past...
the tensor its referring to is the past and presents.
no clue why gpt2 names it like this.
this is a nit because its just a naming convention comment.
otherwise lgtm
@irenedea is this ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit
Fixes the forward pass in MPTModel to update not
past_key_values
in place and instead use a new list,presents
. 🎁 Naming is inspired by gpt2.This addresses the following error:
which occurs during multi-gpu generation for mpt models when one rank hits EOS before the others.