Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixtures #673

Merged
merged 20 commits into from
Oct 25, 2023
Merged

Add fixtures #673

merged 20 commits into from
Oct 25, 2023

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Oct 13, 2023 •
edited
Loading

Adds fixtures to encourage code reuse and make it easier to write tests. For now, only adding mpt fixtures.

Models

  • mpt
  • hf_mpt

Data

  • finetune dataset/dataloader

Other Models

  • llama2
  • neo

@irenedea irenedea marked this pull request as ready for review October 18, 2023 05:16
@irenedea
Copy link
Contributor Author

irenedea commented Oct 18, 2023 •
edited
Loading

hmm having trouble reproducing the CI code quality error locally, and the types it's complaining about seem to match correctly 🤷‍♀️ will take a closer look ah i think it was because i didn't rebase/merge main and we've updated the dataloader builder return types to dataspec

aspfohl
aspfohl approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@aspfohl aspfohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

tests/fixtures/data.py Outdated Show resolved Hide resolved
tests/fixtures/autouse.py Show resolved Hide resolved
@irenedea irenedea force-pushed the fixtures branch 2 times, most recently from 15efe0f to 3285765 Compare October 24, 2023 19:40
dakinggg
dakinggg approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, definitely a step forward. Thanks for doing this!

tests/fixtures/models.py Outdated Show resolved Hide resolved
tests/fixtures/models.py Outdated Show resolved Hide resolved
tests/fixtures/models.py Outdated Show resolved Hide resolved
tests/fixtures/data.py Show resolved Hide resolved
tests/test_hf_mpt_gen.py Show resolved Hide resolved
@irenedea irenedea force-pushed the fixtures branch 2 times, most recently from 19f4bf0 to b4d588c Compare October 25, 2023 18:47
@irenedea irenedea merged commit ea3279a into mosaicml:main Oct 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@aspfohl aspfohl aspfohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irenedea @aspfohl @dakinggg