-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch exception raised in hf prep properly #749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
Nov 21, 2023
dakinggg
reviewed
Nov 21, 2023
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
dakinggg
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, lets add a test for this. world size 2 with a broken jsonl file should reproduce for the test I think?
dakinggg
reviewed
Nov 21, 2023
dakinggg
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: There is a barrier deadlock in
build_from_hf
if an Exception is raised which causes errored runs to not fail properly and burn compute.Concretely, the non local rank 0 processes depend on a signal file to be written but if a rank 0 process raises an exception then we never reach the
dist.barrier()
state resulting in a deadlock.Solution: We add a try catch around the dataset preparation code to ensure that local rank 0 gets to writing/removing the signal file enabling all processes to reach the
dist.barrier()
state.Tests:
Also ported the
test_finetuning_dataloader_small
to GPU tests since it wasn't being ran