Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the ffn activation func configurable #805

Merged
merged 9 commits into from
Dec 15, 2023
Merged

Make the ffn activation func configurable #805

merged 9 commits into from
Dec 15, 2023

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented Dec 14, 2023

No description provided.

@vchiley vchiley marked this pull request as ready for review December 14, 2023 01:31
irenedea
irenedea reviewed Dec 14, 2023
View reviewed changes
llmfoundry/models/layers/ffn.py Outdated Show resolved Hide resolved
llmfoundry/models/layers/ffn.py Outdated Show resolved Hide resolved
irenedea
irenedea reviewed Dec 14, 2023
View reviewed changes
llmfoundry/models/layers/ffn.py Show resolved Hide resolved
llmfoundry/models/layers/ffn.py Outdated Show resolved Hide resolved
dblalock
dblalock reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@dblalock dblalock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked at local stuff in this review.

llmfoundry/models/layers/ffn.py Show resolved Hide resolved
llmfoundry/models/layers/ffn.py Outdated Show resolved Hide resolved
llmfoundry/models/mpt/configuration_mpt.py Outdated Show resolved Hide resolved
tests/models/test_model.py Outdated Show resolved Hide resolved
tests/models/test_model.py Outdated Show resolved Hide resolved
irenedea
irenedea approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pending removal of the function config input

@vchiley vchiley enabled auto-merge (squash) December 15, 2023 19:44
@vchiley vchiley merged commit 15e79f3 into mosaicml:main Dec 15, 2023
10 checks passed
@vchiley vchiley deleted the cfg_ffn_act branch December 15, 2023 19:49
@vchiley vchiley mentioned this pull request Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenedea irenedea irenedea approved these changes

@dblalock dblalock dblalock left review comments

@sashaDoubov sashaDoubov sashaDoubov approved these changes

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vchiley @dblalock @sashaDoubov @irenedea