Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openai not conditioned imports #806

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Fix openai not conditioned imports #806

merged 6 commits into from
Dec 15, 2023

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Dec 15, 2023 •
edited
Loading

Also adds a smoketest to prevent this issue in the future

Also fixes a typo in the code itself

@dakinggg dakinggg marked this pull request as ready for review December 15, 2023 02:41
@dakinggg dakinggg requested a review from a team as a code owner December 15, 2023 02:41
j316chuck
j316chuck approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@j316chuck j316chuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a question and a nit

.github/workflows/smoketest.yaml Show resolved Hide resolved
tests/test_smoketest.py Show resolved Hide resolved
@dakinggg dakinggg enabled auto-merge (squash) December 15, 2023 02:51
bandish-shah
bandish-shah approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@bandish-shah bandish-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakinggg dakinggg merged commit f56f122 into mosaicml:main Dec 15, 2023
10 checks passed
@dakinggg dakinggg deleted the fix-openai-imports branch February 10, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bandish-shah bandish-shah bandish-shah approved these changes

@j316chuck j316chuck j316chuck approved these changes

@irenedea irenedea Awaiting requested review from irenedea

@maxisawesome maxisawesome Awaiting requested review from maxisawesome

@bmosaicml bmosaicml Awaiting requested review from bmosaicml

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @j316chuck @bandish-shah