-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump composer version #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
approved these changes
May 9, 2023
mvpatel2000
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raising min should not change anything (it will always use 14.1). but we should raise pin anyways
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
* Adding Nemo Megatron readme and example yaml files * making assets * Update README.md Updating nemo readme with assets * Update README.md Updating README wording * removing stray assets * Moving around files * Cleaning up abbreviations, scripts * Update nemo/README.md Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com> * Moving to under examples repo --------- Co-authored-by: Brandon Cui <bcui@Brandons-MacBook-Pro.local> Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was asked to run try this streaming branch out, so I tested updating composer as well. No issues; seems slightly faster on 125m model (might just be runtime variance, but I'm not sure)
![Screenshot 2023-05-09 at 12 57 20 PM](https://private-user-images.githubusercontent.com/6439018/237206497-2d2e6be0-0a82-4138-a70f-31d70df60245.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk4ODQwMzgsIm5iZiI6MTczOTg4MzczOCwicGF0aCI6Ii82NDM5MDE4LzIzNzIwNjQ5Ny0yZDJlNmJlMC0wYTgyLTQxMzgtYTcwZi0zMWQ3MGRmNjAyNDUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMThUMTMwMjE4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmI3YzU2YjI1MjFhZmMzYWU5Nzg4MmQ5YzEwNDA0YmZmMDg0YmIyYzdmOTVlNjI2OTQwMjg0ZDE2NjNiNjJhOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.5oW6OTxGFAeLXY92b21L_bZD7bV74jHsXFalpghUEGs)
![Screenshot 2023-05-09 at 12 57 53 PM](https://private-user-images.githubusercontent.com/6439018/237206621-ab3816f8-57e6-4d17-aa90-bb14855e7b80.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk4ODQwMzgsIm5iZiI6MTczOTg4MzczOCwicGF0aCI6Ii82NDM5MDE4LzIzNzIwNjYyMS1hYjM4MTZmOC01N2U2LTRkMTctYWE5MC1iYjE0ODU1ZTdiODAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMThUMTMwMjE4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWYxYTc1MzhiZWRhNDY2YWY4ZGJmNDUyMDY2Y2NlZjBiY2UxMzk0MDY0M2ZlMGY4MmEwNDEzODU0YjVmZDEzOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.x9MwrVoEClNMJkgaOX-aLXUFggzdWpTFmX_UC6cJY90)