Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hf dict cfg overrides #90

Merged
merged 5 commits into from
May 11, 2023
Merged

hf dict cfg overrides #90

merged 5 commits into from
May 11, 2023

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented May 10, 2023

fixes issue: #89

@vchiley vchiley requested a review from dakinggg May 10, 2023 03:58
@vchiley vchiley self-assigned this May 10, 2023
dakinggg
dakinggg approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a unit test?

@bjoernpl bjoernpl mentioned this pull request May 10, 2023
Closed
@vchiley vchiley requested a review from dakinggg May 10, 2023 20:27
@dakinggg dakinggg mentioned this pull request May 10, 2023
Merged
@alextrott16
Copy link
Contributor

Should these same changes be incorporated into hf_prefix_lm.py and hf_t5.py?

@samhavens samhavens mentioned this pull request May 11, 2023
Closed
@vchiley vchiley requested a review from dakinggg May 11, 2023 01:46
dakinggg
dakinggg approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

llmfoundry/models/hf/hf_causal_lm.py Outdated Show resolved Hide resolved
@vchiley vchiley merged commit 73ff8a0 into mosaicml:main May 11, 2023
@vchiley vchiley mentioned this pull request May 11, 2023
Closed
bmosaicml pushed a commit that referenced this pull request Jun 6, 2023
@abhi-mosaic
Make everything pip installable (#90)
7e6cf84 
This PR touches almost every file, but it is mainly shuffling files around:
* move all code under examples/examples
* change setup.py to install everything
* update READMEs and import statements
* many bugfixes
bmosaicml pushed a commit that referenced this pull request Jun 6, 2023
@vchiley
hf dict cfg overrides (#90)
158c3a8 
* hf dict cfg overrides

* custom dict overrides with checks; set all init defaults

* pr cmt
@vchiley vchiley deleted the hf_cfg_overrides branch November 9, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees

@vchiley vchiley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vchiley @alextrott16 @dakinggg