Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the maximum number of retry attempts for boto3 #852

Closed
jamin-chen opened this issue Dec 17, 2024 · 2 comments
Closed

Allow setting the maximum number of retry attempts for boto3 #852

jamin-chen opened this issue Dec 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jamin-chen
Copy link

🚀 Feature Request

Currently the retries in S3Downloader are configured like so:

retries = {
'mode': 'adaptive',
}

boto3 supports passing in a max_attempts key to this dictionary which sets the maximum number of request retries. The default value is 3 but we'd like to increase this value because we are seeing flakey behavior from some object storage providers.

[Optional] Implementation

You could allow users to set the envvar S3_MAX_ATTEMPTS.

@ricor07
Copy link

ricor07 commented Dec 26, 2024

Hello, I'd be glad to contribute to the project by fixing the issue. Can you assign it to me? Thanks

@snarayan21
Copy link
Collaborator

Hey @ricor07, as mentioned in the comment to the attached PR, you can already specify the download_retry argument to StreamingDataset to get download retry functionality across any cloud provider.

@jamin-chen going to close out this issue as per our discussion on #853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants