Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the number of retries for boto3 #853

Closed
wants to merge 1 commit into from

Conversation

jamin-chen
Copy link

@jamin-chen jamin-chen commented Dec 17, 2024

Description of changes:

Users can configure the number of retries that boto3 will use by setting the MOSAICML_STREAMING_AWS_MAX_ATTEMPTS envvar.

Issue #, if available:

Fixes #852

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@snarayan21
Copy link
Collaborator

Hey @jamin-chen , this seems fine, but does the download_retry argument to StreamingDataset not work for you? We already wrap all downloads with retry logic that uses this arg.
See

download_retry (int): Number of download re-attempts before giving up. Defaults to ``2``.

@jamin-chen
Copy link
Author

Oh whoops I completely missed that, I'll try that out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting the maximum number of retry attempts for boto3
2 participants