Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCS authentication for service accounts #315

Merged
merged 15 commits into from
Jun 29, 2023

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Jun 26, 2023

Description of changes:

Allow authentication with GCS for service accounts

Issue #, if available:

STR-69

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

streaming/base/storage/upload.py Outdated Show resolved Hide resolved
streaming/base/storage/upload.py Outdated Show resolved Hide resolved
streaming/base/storage/upload.py Outdated Show resolved Hide resolved
streaming/base/storage/upload.py Outdated Show resolved Hide resolved
tests/test_upload.py Outdated Show resolved Hide resolved
tests/test_upload.py Outdated Show resolved Hide resolved
streaming/base/storage/download.py Outdated Show resolved Hide resolved
streaming/base/storage/download.py Show resolved Hide resolved
streaming/base/storage/upload.py Outdated Show resolved Hide resolved
streaming/base/storage/upload.py Outdated Show resolved Hide resolved
streaming/base/storage/upload.py Outdated Show resolved Hide resolved
streaming/base/storage/upload.py Show resolved Hide resolved
streaming/base/storage/upload.py Outdated Show resolved Hide resolved
streaming/base/storage/upload.py Outdated Show resolved Hide resolved
@b-chu b-chu requested a review from karan6181 June 29, 2023 15:08
Copy link
Collaborator

@karan6181 karan6181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank You!

@b-chu b-chu enabled auto-merge (squash) June 29, 2023 15:50
@b-chu b-chu disabled auto-merge June 29, 2023 15:50
@b-chu b-chu enabled auto-merge (squash) June 29, 2023 15:51
@b-chu b-chu merged commit da53bc5 into mosaicml:main Jun 29, 2023
@b-chu b-chu deleted the gcs_service_account branch June 29, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants