-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for downloading from Unity Catalog volumes #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karan6181
reviewed
Aug 4, 2023
karan6181
reviewed
Aug 4, 2023
karan6181
reviewed
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. Few minor comments:
- Can you also add the similar functionality in upload.py which basically uploads the shard files in UC during dataset conversion? You can look at PR 311 and 265 for reference.
- Can you also add a unit test for the same in test_download.py and test_upload.py ?
- Can you also update the documentation with UC Volume section on how user would provide a credentials ?
Thanks!
maddiedawson
changed the title
Add utils to check and set UC token
Add support for downloading from Unity Catalog volumes
Aug 10, 2023
maddiedawson
force-pushed
the
hackathon2
branch
from
August 14, 2023 22:07
988e827
to
d816526
Compare
Done
Done
Done
|
maddiedawson
force-pushed
the
hackathon2
branch
from
August 15, 2023 19:53
527c7f9
to
a67550f
Compare
The PR looks good to me, Can you rebase the PR and then fixed the lint issue which I mentioned in PR 362? Thanks! |
maddiedawson
force-pushed
the
hackathon2
branch
from
August 22, 2023 23:44
a67550f
to
939c8f2
Compare
maddiedawson
force-pushed
the
hackathon2
branch
from
August 23, 2023 18:36
939c8f2
to
ce1ad36
Compare
maddiedawson
force-pushed
the
hackathon2
branch
from
August 23, 2023 18:48
ce1ad36
to
84f2c31
Compare
karan6181
reviewed
Aug 23, 2023
karan6181
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change allows users to upload data to and download data from Databricks Unity Catalog.
To configure authentication using mcli, user would run:
Env vars consistent with https://databricks-sdk-py.readthedocs.io/en/latest/authentication.html
Issue #, if available:
STR-116
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)