-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Databricks File System backend #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Few minor comments:
- How does the dbfs authentication happens? I think it might be related to the UC Volume PR that you have created ?
- Can you also add the similar functionality in upload.py which basically uploads the shard files in UC during dataset conversion? You can look at PR 311 and 265 for reference.
- Can you also add a unit test for the same in test_download.py and test_upload.py ?
- Can you also update the documentation with UC Volume section on how user would provide a credentials ?
Thanks!
e4cc257
to
210a7cc
Compare
I added some details to the docs; users will set
Done
Done
Done
|
docs/source/how_to_guides/configure_cloud_storage_credentials.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For CI test failure, you can change this line to "[all]"
which will install all the extra dependency packages.
Done |
For the lint failure, Can you please add the below lines in this file ? I have verified it and now the lint will pass.
|
Done |
Description of changes:
Add support for uploading data to and downloading data from Databricks File System (DBFS)
Issue #, if available:
STR-128
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)