-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bench/plot sample access times across data and across formats #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
karan6181
reviewed
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great.
- Can you add a README under
scripts/samples/
directory explaining how to run this script and how to interpret the output ? This would help internal and external user to run the script in future !! - As you have mentioned in the description, it would be good idea to split this into
bench_text.py
,bench_tokens.py
,plot.py
files. Not a blocker for this PR, but definitely an improvement.
karan6181
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Benchmark and plot sample access times across different kinds of data (text, tokens) and different shard formats (MDS, JSONL, CSV).
On my system, this distribution reliably looks like one big spike (as expected) followed by seemingly a second much smaller hump, continuing to fade out very rapidly. I attribute this second rise to some kind of small linear-ish slowdown somewhere affecting the main spike plus the log-scaled bucketing and plotting: the buckets get wider in linear terms as you ascend to the right on the plot.
We probably want to break this into
bench_text.py
,bench_tokens.py
,plot.py
?Issue #, if available:
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)