-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve shard efficiency of sampling for fractional stream repeats. #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into james/sparse-sampling
… into james/sparse-sampling
karan6181
reviewed
Sep 6, 2023
karan6181
reviewed
Sep 6, 2023
snarayan21
reviewed
Sep 7, 2023
snarayan21
requested changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some clarification stuff like comments and duplicate variable names, other than that lgtm
karan6181
reviewed
Sep 8, 2023
… into james/sparse-sampling
karan6181
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a StreamingDataset argument
sampling_granularity: int = 1
, which determines how many samples are drawn from the same shard at a time when sampling a stream.At
1
, each sample is drawn independently for the partial repeat if any.At
100
, up to a hundred samples are pulled at a time from the same shard, limited by the number of un-picked samples left in the shard, for the partial repeat if any.If shard usage efficiency is especially a concern, you would set
sampling_granularity
to the size of the biggest shard (500
?50000
?) in order to fully exhaust one shard a time.Issue #, if available:
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)