Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fancy overly long lines command. #529

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fancy overly long lines command. #529

merged 1 commit into from
Dec 12, 2023

Conversation

knighton
Copy link
Contributor

@knighton knighton commented Dec 12, 2023 •
edited
Loading

Detect overlong lines in technicolor, noting files and line numbers, not just grepping the lines.

Returning a meaningful exit code, this is intended to be added to the precommit checks in a subsequent PR.

@knighton
Copy link
Contributor Author

hmm

snarayan21
snarayan21 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! lgtm 👍

@knighton knighton merged commit 0ecf06f into dev Dec 12, 2023
6 checks passed
@knighton knighton deleted the james/nice-overlong branch December 12, 2023 02:03
karan6181 pushed a commit that referenced this pull request Jan 26, 2024
@knighton @karan6181
Fancy overly long lines command. (#529)
4714c07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 approved these changes

@karan6181 karan6181 Awaiting requested review from karan6181 karan6181 is a code owner

@bandish-shah bandish-shah Awaiting requested review from bandish-shah bandish-shah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knighton @snarayan21