Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch linting workflows to ci-testing repo #616

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Switch linting workflows to ci-testing repo #616

merged 1 commit into from
Mar 5, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Feb 29, 2024

Description of changes:

Change the linting workflows to use the ones in mosaicml/ci-testing

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@snarayan21
Copy link
Collaborator

@b-chu looks like your own change found issues with....your own change. played yo self

Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting issues lol

@karan6181
Copy link
Collaborator

pre-commit has been passing as part of workflow Linting / pre-commit (3.9, [dev,testing]) (pull_request).

@karan6181 karan6181 merged commit ea29eaf into main Mar 5, 2024
6 checks passed
@karan6181 karan6181 deleted the linting branch March 5, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants