Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[question] Conflict with Passenger and Node Cluster module #565

Closed
mer30boy opened this issue Dec 3, 2020 · 5 comments · Fixed by #567
Closed

[question] Conflict with Passenger and Node Cluster module #565

mer30boy opened this issue Dec 3, 2020 · 5 comments · Fixed by #567
Labels
question

Comments

@mer30boy
Copy link

mer30boy commented Dec 3, 2020

Aedes uses shortid
But shortid required the Node Cluster module, which is incompatible with Passenger, a non-functional shim was returned and your app may still work.
However, please remove or replace the related package as soon as possible.
@robertsLando
Copy link
Member

@mer30boy PR?

@mer30boy
Copy link
Author

mer30boy commented Dec 6, 2020

I am a novice and I do not have the ability to do this

@robertsLando
Copy link
Member

@mer30boy shortid is only used for clients ids on connect. If your clients specify a client id it will never be used.

@mcollina Do you think we should replace shortid module?

@mcollina
Copy link
Collaborator

mcollina commented Dec 7, 2020

I wrote https://www.npmjs.com/package/hyperid a long time ago.

robertsLando added a commit that referenced this issue Dec 7, 2020
@robertsLando
fix: replace shortid with hyperid #565
d61c825
@robertsLando robertsLando mentioned this issue Dec 7, 2020
Merged
@robertsLando
Copy link
Member

@mer30boy PR submitted

robertsLando added a commit that referenced this issue Dec 7, 2020
@robertsLando
fix: replace shortid with hyperid #565 (#567)
831048b
robertsLando added a commit that referenced this issue Dec 7, 2020
@robertsLando
fix: replace shortid with hyperid #565 (#568)
b682531 
mqtt-packet                         ^6.6.0  →     ^6.7.0
 @types/node                       ^14.14.6  →  ^14.14.10
 @typescript-eslint/eslint-plugin    ^4.6.0  →     ^4.9.0
 @typescript-eslint/parser           ^4.6.0  →     ^4.9.0
 mqtt                                ^4.2.4  →     ^4.2.6
 release-it                         ^14.2.1  →    ^14.2.2
 standard                           ^16.0.1  →    ^16.0.3
 tap                               ^14.10.8  →   ^14.11.0
 typescript                          ^4.0.5  →     ^4.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace shortid with hyperid #565 moscajs/aedes
3 participants
@mcollina @robertsLando @mer30boy