Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing brokerId while deleting will #105

Merged
merged 3 commits into from
Apr 14, 2017
Merged

Passing brokerId while deleting will #105

merged 3 commits into from
Apr 14, 2017

Conversation

GavinDmello
Copy link
Collaborator

No description provided.

@GavinDmello GavinDmello changed the title Passing brokerId during delWill Passing brokerId while deleting will Apr 13, 2017
@coveralls
Copy link

coveralls commented Apr 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.416% when pulling c9d3442 on passWill into efa6553 on master.

@coveralls
Copy link

coveralls commented Apr 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.416% when pulling cb16c29 on passWill into efa6553 on master.

@coveralls
Copy link

coveralls commented Apr 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.416% when pulling d113b15 on passWill into efa6553 on master.

@nguyenthenguyen
Copy link
Contributor

Should we publish old will message ?
https://github.com/mcollina/aedes/blob/master/aedes.js#L98
In case, will topic will publish on first time server _clearWillInterval before old will deleted ?
#98 (comment)

@GavinDmello
Copy link
Collaborator Author

@nguyenthenguyen Nice question. I feel it should be published because the clients did disconnect ungracefully and then reconnect when the broker restarted . @mcollina What do you think ?

@mcollina
Copy link
Collaborator

@nguyenthenguyen no, the replacement is just internal, not logical.

@mcollina mcollina merged commit 7431060 into master Apr 14, 2017
@mcollina mcollina deleted the passWill branch April 14, 2017 09:06
@nguyenthenguyen nguyenthenguyen mentioned this pull request Jul 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GavinDmello @coveralls @nguyenthenguyen @mcollina