Do not forward $SYS topics for +/# subscriptions. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinDmello
reviewed
Jul 21, 2017
aedes.js
Outdated
| function removeSharp (sub) { | ||
| return sub.topic !== '#' | ||
| var code = sub.topic.charCodeAt(0) | ||
| console.log(sub.topic, code) |
|
This may affect the #123 change we were planning on implementing |
mcollina
force-pushed
the
block-sys-with-plus
branch
from
68d14e2
to
b369602
Compare
|
@GavinDmello yes. Better to have the tests in. |
GavinDmello
approved these changes
Jul 21, 2017
|
✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #135
@ckrey