Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade tap #611

Merged
merged 7 commits into from
Apr 6, 2021
Merged

chore: upgrade tap #611

merged 7 commits into from
Apr 6, 2021

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Apr 6, 2021

No description provided.

@gnought gnought requested review from robertsLando and mcollina April 6, 2021 10:31
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando
Copy link
Member

I also fixed required checks in branch rules now.

@gnought gnought merged commit 4d7b438 into moscajs:main Apr 6, 2021
@gnought gnought deleted the bugfix/upgrade_tap branch April 6, 2021 14:42
chfritz pushed a commit to chfritz/aedes that referenced this pull request Feb 3, 2025
* Verify object type by t.type

* Upgrade tap

* replace deprecated tap functions

* replace deprecated tap functions

* disable check-coverage warning as an error

* Add .taprc

* Update package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants