Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade Aedes.d.ts and Client to extends from EventEmitter #625

Merged
merged 2 commits into from
Apr 22, 2021
Merged

fix: upgrade Aedes.d.ts and Client to extends from EventEmitter #625

merged 2 commits into from
Apr 22, 2021

Conversation

cjimenezsaiz
Copy link
Contributor

Aedes and Client interfaces has been upgraded as an extends from EventEmitter in order to allow a complete events management in TypeScript applications

@cjimenezsaiz cjimenezsaiz mentioned this pull request Apr 22, 2021
Open
@robertsLando
Copy link
Member

Please fix tests

types/client.d.ts:4:7
  ✖  4:7  Module "events" can only be default-imported using the esModuleInterop flag  

  types/instance.d.ts:5:7
  ✖  5:7  Module "events" can only be default-imported using the esModuleInterop flag

@coveralls
Copy link

Pull Request Test Coverage Report for Build 774352626

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.91%
Totals Coverage Status
Change from base Build 763934071: 0.0%
Covered Lines: 797
Relevant Lines: 797
💛 - Coveralls

@robertsLando robertsLando changed the title fix: upgrade Aedes and Client interfaces to extends from EventEmitter fix: upgrade Aedes.d.ts and Client to extends from EventEmitter Apr 22, 2021
@robertsLando robertsLando merged commit aa8a661 into moscajs:main Apr 22, 2021
chfritz pushed a commit to chfritz/aedes that referenced this pull request Feb 3, 2025
@cjimenezsaiz @chfritz
fix: upgrade Aedes.d.ts and Client to extends from EventEmitter (mosc…
1c3b108 
…ajs#625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjimenezsaiz @robertsLando @coveralls