-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nolocal flag support for bridges #737
Conversation
Also please add a unit test that covers this and fix broken tests |
@gnought Opinions on this one? |
Pull Request Test Coverage Report for Build 2232406743
💛 - Coveralls |
Pull Request Test Coverage Report for Build 2232406743Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this PR @oldrich-s ! Is it ready to merge?
I have just added qos 1 test (just to be sure that persistence works as expected). But otherwise I believe it is ready to be merged. |
Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good to merge?
yeps 👍 |
#736