fix: typescript issue related to aedes.handle and client

[haci-xplora]

ref: issue 801

[robertsLando]

No need to set it to null simply add the ? parameter, when omitted it will be undefined

[haci-xplora]

to specify optional parameter in JavaScript, I have to assign it to null and then go and fix that in TypeScript type definition accordingly.

what do you think?

[haci-xplora]

also we should not use expressions like {} as IncomingMessage in some tests. we can use null now.

shall I fix that as well?

[robertsLando]

I dunno what you mean, does using the changes I suggest here creates errors somewhere?

[haci-xplora]

if you do not want to change javascript files, but only typescript files, that would work. but then the discrepancy between the code and the documentation stays.

[haci-xplora]

changes on js files undone.

[haci-xplora]

almost undefined vs null

it's been an interesting discussion

[coveralls]

Pull Request Test Coverage Report for Build 3823427449

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 99.739%

---

Totals
Change from base Build 3702154582:	0.0%
Covered Lines:	816
Relevant Lines:	816

---

💛 - Coveralls

[robertsLando]

@haci-xplora I think it may make sense to also add a types test here that also calls handle without the req to prevent regressions

After that this is good to merge 👍🏼

[robertsLando]

Superseded by #812