Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): update username and password type definition #806

Merged
merged 4 commits into from
Jan 13, 2023
Merged

fix(types): update username and password type definition #806

merged 4 commits into from
Jan 13, 2023

Conversation

adipascu
Copy link
Contributor

@adipascu adipascu commented Jan 12, 2023 •
edited
Loading

The username and password variables have the undefined type when not set in the MQTTX client.

@adipascu
Update password type definition
0999ecc 
The password has the undefined type when not set in the MQTTX client.
@adipascu
Update username type definition
2abf9eb 
The username has the undefined type when not set in the MQTTX client.
robertsLando
robertsLando requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix types tests issues

@adipascu adipascu changed the title Update password type definition Update username and password type definition Jan 13, 2023
@coveralls
Copy link

coveralls commented Jan 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3910922203

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.739%
Totals Coverage Status
Change from base Build 3872893134: 0.0%
Covered Lines: 816
Relevant Lines: 816
💛 - Coveralls

@robertsLando robertsLando changed the title Update username and password type definition fix(types): update username and password type definition Jan 13, 2023
@robertsLando robertsLando merged commit 7c2a2b9 into moscajs:main Jan 13, 2023
@adipascu adipascu deleted the patch-1 branch January 13, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adipascu @coveralls @robertsLando