Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete already closed client on closeSameClients #929

Merged

Conversation

Gianluca-Casagrande-Stiga
Copy link
Contributor

No description provided.

@Gianluca-Casagrande-Stiga
Copy link
Contributor Author

This should resolve #928, but I would like to add a related test

@Gianluca-Casagrande-Stiga Gianluca-Casagrande-Stiga marked this pull request as draft January 8, 2024 17:06
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "aedes",
"version": "0.50.1",
"version": "0.50.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not bump version please, It's automatically done on release

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test?

@robertsLando robertsLando changed the title delete already closed client on closeSameClients fix: delete already closed client on closeSameClients Jan 9, 2024
@coveralls
Copy link

coveralls commented Jan 9, 2024

Pull Request Test Coverage Report for Build 7503794175

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.742%

Totals Coverage Status
Change from base Build 7503784074: 0.001%
Covered Lines: 823
Relevant Lines: 823

💛 - Coveralls

@robertsLando robertsLando marked this pull request as ready for review January 9, 2024 16:35
@robertsLando robertsLando merged commit f42882c into moscajs:main Jan 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants