Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

fix 148 #156

Merged
merged 1 commit into from
Jun 24, 2014
Merged

fix 148 #156

merged 1 commit into from
Jun 24, 2014

Conversation

mocheng
Copy link
Contributor

@mocheng mocheng commented Jun 24, 2014

Fix #148

Mosca should survive client "unsubscribe" command before any "subscibe" command.

@mcollina
Copy link
Collaborator

As I said in the previous issue, we might decide to remove that sub.handler check, and maybe create a class for the subscriptions.
Have a look at: #148 (comment).

@mocheng
Copy link
Contributor Author

mocheng commented Jun 24, 2014

Before sub.handler check is removed, I believe that Mosca need this fix. Otherwise, if any client try to unsubscribe a topic before subscribe it, it would make Mosca server crash.

mcollina added a commit that referenced this pull request Jun 24, 2014
@mcollina mcollina merged commit d992743 into moscajs:master Jun 24, 2014
@mocheng mocheng deleted the fix_148 branch June 25, 2014 01:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants