This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
Call unsubAndClose on client timeout instead of close. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also help with Issue #55 |
|
This branch fails on node 0.8, not really sure what the issue is :(. |
|
This should be fixed by #57. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the error: "tryint to send a packet to a disconnected client" after a mosca was running for a while. Traced it down to timed out clients not calling the correct close method. They should be calling unsubAndClose instead of just close. Tried to add a test case for this, but wasn't able to successfully repro this in the unit test framework.