Turn off infer_residues for visualize step #1129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
I bump into the case when visualize big compound becomes extremely slow. I was able to determine the bottle neck, which is the
pull_residues
step when converting from mbuild to parmed (to save out to a mol2 file) when theinfer_residue
isTrue
. This PR will turn that option off, and we probably need to look into optimize thepull_residues
method in the near future.PR Checklist