fix: delete the task if the notifier channel is closed #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <kemingy94@gmail.com>
There seems no easy way to avoid this, maybe let's keep it for now? |
Signed-off-by: Keming <kemingy94@gmail.com>
lkevinzc
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keming kemingy94@gmail.com
This is because when this connection is closed, the corresponding server tokio thread is also dead. So the created notifier channel is closed. Thus we need to delete the task since no one is going to use it.
Also, it's a bit ugly to put the metrics info in this task related method. Welcome other suggestions.
If it looks good, I'll also update the version and release a new one.