Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add endpoint label to the code metrics #437

Merged
merged 1 commit into from
Aug 27, 2023
Merged

feat: add endpoint label to the code metrics #437

merged 1 commit into from
Aug 27, 2023

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Aug 26, 2023

@kemingy
feat: add endpoint label to the code metrics
9b86f20 
Signed-off-by: Keming <kemingy94@gmail.com>
@github-actions github-actions bot added the enhancement New feature or request label Aug 26, 2023
@kemingy
Copy link
Member Author

kemingy commented Aug 26, 2023

Not sure if we should add the endpoint label to the remaining_task. 🤔

@kemingy kemingy enabled auto-merge August 26, 2023 08:08
@lkevinzc
Copy link
Member

Not sure if we should add the endpoint label to the remaining_task. 🤔

I feel the information of remaining task per endpoint is not that important, can leave it for future work if needed.

@lkevinzc lkevinzc self-requested a review August 27, 2023 07:02
@kemingy kemingy added this pull request to the merge queue Aug 27, 2023
Merged via the queue into mosecorg:main with commit 4f5160b Aug 27, 2023
13 checks passed
@kemingy kemingy deleted the metric_endpoint branch August 27, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkevinzc lkevinzc lkevinzc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add route-level metrics
2 participants
@kemingy @lkevinzc