Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add arm in ci #510

Merged
merged 9 commits into from
Feb 29, 2024
Merged

test: add arm in ci #510

merged 9 commits into from
Feb 29, 2024

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Feb 27, 2024

  1. add macOS ARM test
  2. run lint and test in parallel to make it faster
  3. upload the sdist before the cargo publish, just in case I forgot to update the version in the Cargo.toml

@kemingy
test: add arm in ci
f2ef1c2 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
skip macos14 py3.8 since it's not supported
a275f42 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
set up rust explicitly
4bced61 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy kemingy marked this pull request as draft February 27, 2024 09:41
@kemingy
test if cargo is installed
b4ec2d8 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
rm cache in test
245823f 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
add clippy explicitly
e6f28d5 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
typo
340196b 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
fix numbin error on ARM macOS
2d390d1 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
exclude py3.9 arm
bda4ffb 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy kemingy marked this pull request as ready for review February 29, 2024 01:06
lkevinzc
lkevinzc approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@lkevinzc lkevinzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed on m1 with numbin 0.5.0.

@lkevinzc lkevinzc added this pull request to the merge queue Feb 29, 2024
Merged via the queue into mosecorg:main with commit 6bd49e4 Feb 29, 2024
16 checks passed
@kemingy kemingy deleted the ci_test_arm branch May 21, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkevinzc lkevinzc lkevinzc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kemingy @lkevinzc