Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: annotations lazy evaluation #538

Merged
merged 2 commits into from
Jun 16, 2024
Merged

fix: annotations lazy evaluation #538

merged 2 commits into from
Jun 16, 2024

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Jun 15, 2024 •
edited
Loading

from __future__ import annotations will enable the annotations lazy evaluation which changes all the annotations into strings. We have to eval these strings to get the real objects.

@kemingy
fix: annotations lazy evaluation
47b3ae6 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
relax dev dep version
76c7ca0 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy kemingy enabled auto-merge June 15, 2024 17:35
@kemingy kemingy requested a review from lkevinzc June 15, 2024 17:36
@github-actions github-actions bot added bug_fix and removed bug_fix labels Jun 15, 2024
@kemingy kemingy added this pull request to the merge queue Jun 16, 2024
Merged via the queue into mosecorg:main with commit eabcfea Jun 16, 2024
18 checks passed
@kemingy kemingy deleted the fix_annotations branch June 16, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkevinzc lkevinzc lkevinzc approved these changes

Assignees
No one assigned
Labels
bug_fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: rerank example got an error
2 participants
@kemingy @lkevinzc