Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refined worker and init logic #79

Merged
merged 10 commits into from
Oct 23, 2021
Merged

refined worker and init logic #79

merged 10 commits into from
Oct 23, 2021

Conversation

lkevinzc
Copy link
Member

@lkevinzc lkevinzc commented Oct 22, 2021

  • add worker id for user codes to access: useful for conditional resource allocation
  • warm up workers first then establish connections, after which the http server is allowed to start
  • make metadata single source
  • change logging of examples to INFO level to make it more user friendly

@lkevinzc lkevinzc requested a review from kemingy October 22, 2021 14:27
@lkevinzc lkevinzc enabled auto-merge (squash) October 22, 2021 14:27
Cargo.toml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
src/protocol.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@kemingy
Copy link
Member

kemingy commented Oct 23, 2021

* make metadata single source

Not sure if this is necessary.

* change logging of examples to INFO level to make it more user friendly

Maybe the echo demo can use the DEBUG level to demonstrate what happened? BTW, sleep too long is not very user-friendly for a simple demo.

@lkevinzc lkevinzc merged commit e912e3f into main Oct 23, 2021
@kemingy kemingy deleted the worker-id branch October 23, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants