Fix StdioOverrideFunction Type export #41
Merged
+78
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshen
force-pushed
the
fix-stdiooverridefunction-type
branch
3 times, most recently
from
d7c5b07
to
84188c9
Compare
This was a case of bad management of the types in play and their exposure outside the package. The fix that works for both package maintenance, and external users is to ensure that the type is available and copied into the final npm package. Finally this would have been caught with a test, which has now been added. - Fix #40 - Add dedicated type file for StdioOverrideFunction - Change type file paths to be relative - Move all type files to the `src` folder to make things easier - Add Makefile rules to copy over `.d.ts` files so they are in the package
moshen
force-pushed
the
fix-stdiooverridefunction-type
branch
from
84188c9
to
91e0178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a case of bad management of the types in play and their exposure outside the package. The fix that works for both package maintenance, and external users is to ensure that the type is available and copied into the final npm package. Finally this would have been caught with a test, which has now been added.
srcfolder to make things easier.d.tsfiles so they are in the package