Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_link() to many links #75

Closed
hschult opened this issue Sep 16, 2024 · 1 comment
Closed

to_link() to many links #75

hschult opened this issue Sep 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@hschult
Copy link

hschult commented Sep 16, 2024

Hi and thank you for this awesome plotting library!

Unfortunately, I may have found a small bug. Running this code I get (with pycirclize 1.6.0 and 1.7.0):

import pandas as pd
import pycirclize

table = pd.DataFrame({"from": ["a"], "to": ["aa"], "value": [1]})

pycirclize.parser.Matrix.parse_fromto_table(table).to_links()

-> [(('aa', 0.0, 1.0), ('a', 1.0, 0.0)), (('a', 1.0, 2.0), ('aa', 2.0, 1.0))] but I expected [(('a', 0.0, 1.0), ('aa', 1.0, 0.0))].
Interestingly, when I rename "aa" to "a1" this works as expected.

moshi4 added a commit that referenced this issue Sep 20, 2024
Fix to calc correct chord links for similar `from` & `to` label table
@moshi4 moshi4 mentioned this issue Sep 20, 2024
@moshi4
Copy link
Owner

moshi4 commented Sep 20, 2024

Hi @hschult,

Thank you for report this bug. Fixed in v1.7.1 release.

@moshi4 moshi4 closed this as completed Sep 20, 2024
@moshi4 moshi4 added the bug Something isn't working label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants