Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add withDumpTo logs #93

Merged
merged 13 commits into from
Mar 31, 2022
Merged

docs: add withDumpTo logs #93

merged 13 commits into from
Mar 31, 2022

Conversation

Jun10ng
Copy link
Contributor

@Jun10ng Jun10ng commented Mar 31, 2022

No description provided.

@Jun10ng Jun10ng changed the title docs docs: add withDumpTo logs Mar 31, 2022
@Jun10ng
Copy link
Contributor Author

Jun10ng commented Mar 31, 2022 •
edited
Loading

好奇怪，为什么这么多commit。

难道我操作方式有问题吗？

我直接在自己的master分支上进行修改，并和mosn:master同步。但是提mr的时候，还有上个mr的commit（内容为空）被对比出来。

感觉是 签入主分支的时候，holmes把commits squash了。

@doujiang24
Copy link
Member

好奇怪，为什么这么多commit。

难道我操作方式有问题吗？

是的，你的习惯不太好，建议开发的时候，新搞分支，master 保持与 upstream 同步
更多可见：
https://mosn.io/docs/dev/contribute/

@doujiang24 doujiang24 merged commit e0ee2d0 into mosn:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doujiang24 doujiang24 doujiang24 approved these changes

Assignees
No one assigned
Labels
cla:yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jun10ng @doujiang24