feat:#96 #98
Merged
feat:#96 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doujiang24
reviewed
May 15, 2022
holmes.go
Outdated
| @@ -72,7 +72,7 @@ type Holmes struct { | |||
| } | |||
|
|
|||
| type ProfileReporter interface { | |||
| Report(pType string, buf []byte, reason string, eventID string) error | |||
| Report(pType string, dumpName string, reason string, eventID string) error | |||
| writer.WriteField("token", r.token) // nolint: errcheck | ||
| writer.WriteField("profile_type", ptype) // nolint: errcheck | ||
| writer.WriteField("dumpName", dumpName) // nolint: errcheck |
There was a problem hiding this comment.
这个 reporter，需要直接把文件内容也传上去的呢
此处应该是需要读文件呢，这里的服务端接口要求的呢
There was a problem hiding this comment.
入参是filename,在这里读取文件是吧
doujiang24
reviewed
May 16, 2022
| writer.WriteField("token", r.token) // nolint: errcheck | ||
| writer.WriteField("profile_type", ptype) // nolint: errcheck | ||
| writer.WriteField("filename", filename) // nolint: errcheck |
| return fmt.Errorf("write buf to file part err: %v", err) | ||
|
|
||
| // read filename | ||
| if filename != "" { |
There was a problem hiding this comment.
这个判断感觉可以删掉，caller 会保证 filename 不是空
如果这里判断的话，为空的时候，就应该报错，而不是继续上报呢
doujiang24
approved these changes
May 19, 2022
|
@songzhibin97 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.