-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sequencer redis #152
sequencer redis #152
Conversation
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 45.73% 45.62% -0.12%
==========================================
Files 46 46
Lines 1725 1725
==========================================
- Hits 789 787 -2
- Misses 886 887 +1
- Partials 50 51 +1
Continue to review full report at Codecov.
|
ZLBer同学太强了 👍 👍 👍 |
另外看代码的时候突然想到个问题,记录下: |
这个很有必要 |
恩恩我记了个issue给自己 稍后会改掉 #154 |
@seeflood 新的commit修改了上面的问题 并修改了segmentResponse |
@seeflood new commit for above problem |
看着没问题了,就是之前我提了个pr,把组件的一些模板代码(比如创建redis和etcd客户端的代码)抽出来成一个公用的工具类了 |
另外就是需要在组件配置文档里声明,redis组件可能出现id冲突,为了避免冲突需要使用单机redis、把持久化配置都调到最强 |
2. add duplicate id declaration 3. add doc into sidebar
@ZLBer 我给你的分支提交了修改,辛苦你review下哈~包括:
如果你review觉得没问题,我就合并这个pr了哈~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@seeflood LGTM |
* add request time for rpc * change totle time * update * update * update * grpc design docs (#163) * add trace log * change log path * update * sequencer redis (#152) * update * update * [fix] Sequencer redis (#164) fix : for GetSegment method, redis component only check support when size=0. * update * update * update * update * add unittest for runtime and grpc (#169) * update * remove trace time prints * update Co-authored-by: 文徐 <wangwenxue.wwx@alibaba-inc.com> Co-authored-by: 永鹏 <neji_bupt@163.com> Co-authored-by: ZLBer <1098294815@qq.com> Co-authored-by: tianjipeng <tianjipeng@outlook.com>
* add request time for rpc * change totle time * update * update * update * grpc design docs (#163) * add trace log * change log path * update * sequencer redis (#152) * update * update * [fix] Sequencer redis (#164) fix : for GetSegment method, redis component only check support when size=0. * update * update * update * update * add unittest for runtime and grpc (#169) * update * remove trace time prints * update Co-authored-by: 文徐 <wangwenxue.wwx@alibaba-inc.com> Co-authored-by: 永鹏 <neji_bupt@163.com> Co-authored-by: ZLBer <1098294815@qq.com> Co-authored-by: tianjipeng <tianjipeng@outlook.com>
* add request time for rpc * change totle time * update * update * update * grpc design docs (#163) * add trace log * change log path * update * sequencer redis (#152) * update * update * [fix] Sequencer redis (#164) fix : for GetSegment method, redis component only check support when size=0. * update * update * update * update * add unittest for runtime and grpc (#169) * update * remove trace time prints * update Co-authored-by: 文徐 <wangwenxue.wwx@alibaba-inc.com> Co-authored-by: 永鹏 <neji_bupt@163.com> Co-authored-by: ZLBer <1098294815@qq.com> Co-authored-by: tianjipeng <tianjipeng@outlook.com>
* add request time for rpc * change totle time * update * update * update * grpc design docs (#163) * add trace log * change log path * update * sequencer redis (#152) * update * update * [fix] Sequencer redis (#164) fix : for GetSegment method, redis component only check support when size=0. * update * update * update * update * add unittest for runtime and grpc (#169) * update * remove trace time prints * update Co-authored-by: 文徐 <wangwenxue.wwx@alibaba-inc.com> Co-authored-by: 永鹏 <neji_bupt@163.com> Co-authored-by: ZLBer <1098294815@qq.com> Co-authored-by: tianjipeng <tianjipeng@outlook.com>
What this PR does:
add sequencer redis
Which issue(s) this PR fixes:
Fixes #150
Special notes for your reviewer:
@seeflood
Does this PR introduce a user-facing change?: