Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple java client #153

Merged
merged 5 commits into from
Aug 21, 2021
Merged

simple java client #153

merged 5 commits into from
Aug 21, 2021

Conversation

ZLBer
Copy link
Member

@ZLBer ZLBer commented Jul 25, 2021

What this PR does:
add a simple java client , update protobuf and grpc java code, test call rpc successfully.
the client only simply encapsulate the grpc methods , at the same time some methods are not implemented

Which issue(s) this PR fixes:

Fixes #148

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2021

Codecov Report

Merging #153 (1464319) into main (742c3e9) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 1464319 differs from pull request most recent head fe03f40. Consider uploading reports for the commit fe03f40 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   56.47%   56.56%   +0.09%     
==========================================
  Files          51       51              
  Lines        2215     2215              
==========================================
+ Hits         1251     1253       +2     
+ Misses        842      841       -1     
+ Partials      122      121       -1     
Impacted Files Coverage Δ
...kg/filter/network/tcpcopy/persistence/work_pool.go 90.19% <0.00%> (+3.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742c3e9...fe03f40. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood merged commit f593aef into mosn:main Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more features for java sdk
3 participants