Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add lock anno #290

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Feature/add lock anno #290

merged 2 commits into from
Oct 28, 2021

Conversation

LXPWing
Copy link
Member

@LXPWing LXPWing commented Oct 28, 2021

What this PR does:
#112
add comments to lock related code

@mosn-community-bot
Copy link

Hi @LXPWing, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@seeflood
Copy link
Member

Thanks for your contribution!
Please sign the cla so that we can merge this pr

@LXPWing
Copy link
Member Author

LXPWing commented Oct 28, 2021

I have signed the CLA, but it shows here that I have not signed the CLA,What can I do to fix it?
1bfd5450cc02d6d7ecf948ca1818bf6

@seeflood seeflood closed this Oct 28, 2021
@seeflood seeflood reopened this Oct 28, 2021
@seeflood
Copy link
Member

seeflood commented Oct 28, 2021

Sorry for the inconvenience :(
Now the bot seems back to normal

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #290 (5ccf3e2) into main (b3a9740) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   56.73%   56.73%           
=======================================
  Files          48       48           
  Lines        2057     2057           
=======================================
  Hits         1167     1167           
  Misses        768      768           
  Partials      122      122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3a9740...5ccf3e2. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood merged commit b695318 into mosn:main Oct 28, 2021
@seeflood
Copy link
Member

Thanks again for your help,and welcome to the Layotto community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants