Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zk lock ut #364

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix zk lock ut #364

merged 1 commit into from
Dec 14, 2021

Conversation

ZLBer
Copy link
Member

@ZLBer ZLBer commented Dec 14, 2021

What this PR does:
fix zk lock ut fail. New version of gomock requires the expected call times must equals the real call times.

Which issue(s) this PR fixes:

Fixes #363

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/S labels Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #364 (5a37b77) into main (d1b13d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   57.62%   57.62%           
=======================================
  Files          48       48           
  Lines        2289     2289           
=======================================
  Hits         1319     1319           
  Misses        837      837           
  Partials      133      133           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b13d5...5a37b77. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Thanks for your contribution!

Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood merged commit eb92185 into mosn:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ut fails in components package
3 participants